Change in openvpn[master]: dns-scripts: Fix dnssec values in comments and Copyright statement fo...
A message that is not in the archive (sent off-list or not yet received): gerrit.1777553270000.Id6832e3f56420debc8b19d0144d53ca41abb678b@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1645?usp=email
to review the following change.
Change subject: dns-scripts: Fix dnssec values in comments and Copyright statement format
......................................................................
dns-scripts: Fix dnssec values in comments and Copyright statement format
- Fix the example value of dnssec to an actual valid one
- Fix the formatting of the Copyright statements to be consistent with all other files in the project
---
M distro/dns-scripts/haikuos_file-dns-updown.sh M distro/dns-scripts/macos-dns-updown.sh
M distro/dns-scripts/openresolv-dns-updown.sh M distro/dns-scripts/resolvconf_file-dns-updown.sh M distro/dns-scripts/systemd-dns-updown.sh
5 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/45/1645/1
distro/dns-scripts/haikuos_file-dns-updown.sh +2 -2
@@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying Haiku OS resolv.conf -# (C) Copyright 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/macos-dns-updown.sh +2 -2
@@ -2,7 +2,7 @@ # # dns-updown - add/remove openvpn provided DNS information # -# (C) Copyright 2025 OpenVPN Inc <[email protected]...> +# Copyright (C) 2025-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/openresolv-dns-updown.sh +3 -3
@@ -1,8 +1,8 @@ #!/bin/sh # # Simple OpenVPN up/down script for openresolv integration -# (C) Copyright 2016 Baptiste Daroussin -# 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2016 Baptiste Daroussin +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -22,7 +22,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/resolvconf_file-dns-updown.sh +2 -2
@@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying /etc/resolv.conf -# (C) Copyright 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/systemd-dns-updown.sh +1 -1
@@ -29,7 +29,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1645?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id6832e3f56420debc8b19d0144d53ca41abb678b
Gerrit-Change-Number: 1645
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1645?usp=email )
Change subject: dns-scripts: Fix dnssec values in comments and Copyright statement format
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1645?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id6832e3f56420debc8b19d0144d53ca41abb678b
Gerrit-Change-Number: 1645
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Thu, 30 Apr 2026 13:03:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH 1/1 dns-scripts: Fix dnssec values in comments and Copyright statement format
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
- Fix the example value of dnssec to an actual valid one
- Fix the formatting of the Copyright statements to be consistent with all other files in the project
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1645
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1645
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
distro/dns-scripts/haikuos_file-dns-updown.sh +2 -2
@@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying Haiku OS resolv.conf -# (C) Copyright 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/macos-dns-updown.sh +2 -2
@@ -2,7 +2,7 @@ # # dns-updown - add/remove openvpn provided DNS information # -# (C) Copyright 2025 OpenVPN Inc <[email protected]...> +# Copyright (C) 2025-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/openresolv-dns-updown.sh +3 -3
@@ -1,8 +1,8 @@ #!/bin/sh # # Simple OpenVPN up/down script for openresolv integration -# (C) Copyright 2016 Baptiste Daroussin -# 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2016 Baptiste Daroussin +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -22,7 +22,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/resolvconf_file-dns-updown.sh +2 -2
@@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying /etc/resolv.conf -# (C) Copyright 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/systemd-dns-updown.sh +1 -1
@@ -29,7 +29,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
[Openvpn-devel] [PATCH applied] Re: dns-scripts: Fix dnssec values in comments and Copyright statement format
Comments only, but a bugfix nonetheless... well spotted.
Your patch has been applied to the master and release/2.7 branch.
commit 64fbcb69a38b7ae6e7e712e22192c64479fc7759 (master) commit 6528ae0152c07b1710f9c1a892b0b50ea61d8c93 (release/2.7)
Author: Frank Lichtenheld Date: Thu Apr 30 15:03:48 2026 +0200
dns-scripts: Fix dnssec values in comments and Copyright statement format
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1645
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36800.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1645?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dns-scripts: Fix dnssec values in comments and Copyright statement format
......................................................................
dns-scripts: Fix dnssec values in comments and Copyright statement format
- Fix the example value of dnssec to an actual valid one
- Fix the formatting of the Copyright statements to be consistent with all other files in the project
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1645
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36800.html
---
M distro/dns-scripts/haikuos_file-dns-updown.sh M distro/dns-scripts/macos-dns-updown.sh
M distro/dns-scripts/openresolv-dns-updown.sh M distro/dns-scripts/resolvconf_file-dns-updown.sh M distro/dns-scripts/systemd-dns-updown.sh
5 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/45/1645/2
distro/dns-scripts/haikuos_file-dns-updown.sh +2 -2
@@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying Haiku OS resolv.conf -# (C) Copyright 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/macos-dns-updown.sh +2 -2
@@ -2,7 +2,7 @@ # # dns-updown - add/remove openvpn provided DNS information # -# (C) Copyright 2025 OpenVPN Inc <[email protected]...> +# Copyright (C) 2025-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/openresolv-dns-updown.sh +3 -3
@@ -1,8 +1,8 @@ #!/bin/sh # # Simple OpenVPN up/down script for openresolv integration -# (C) Copyright 2016 Baptiste Daroussin -# 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2016 Baptiste Daroussin +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -22,7 +22,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/resolvconf_file-dns-updown.sh +2 -2
@@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying /etc/resolv.conf -# (C) Copyright 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/systemd-dns-updown.sh +1 -1
@@ -29,7 +29,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1645?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id6832e3f56420debc8b19d0144d53ca41abb678b
Gerrit-Change-Number: 1645
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1645?usp=email )
Change subject: dns-scripts: Fix dnssec values in comments and Copyright statement format
......................................................................
dns-scripts: Fix dnssec values in comments and Copyright statement format
- Fix the example value of dnssec to an actual valid one
- Fix the formatting of the Copyright statements to be consistent with all other files in the project
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1645
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36800.html
---
M distro/dns-scripts/haikuos_file-dns-updown.sh M distro/dns-scripts/macos-dns-updown.sh
M distro/dns-scripts/openresolv-dns-updown.sh M distro/dns-scripts/resolvconf_file-dns-updown.sh M distro/dns-scripts/systemd-dns-updown.sh
5 files changed, 10 insertions(+), 10 deletions(-)
distro/dns-scripts/haikuos_file-dns-updown.sh +2 -2
@@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying Haiku OS resolv.conf -# (C) Copyright 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/macos-dns-updown.sh +2 -2
@@ -2,7 +2,7 @@ # # dns-updown - add/remove openvpn provided DNS information # -# (C) Copyright 2025 OpenVPN Inc <[email protected]...> +# Copyright (C) 2025-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/openresolv-dns-updown.sh +3 -3
@@ -1,8 +1,8 @@ #!/bin/sh # # Simple OpenVPN up/down script for openresolv integration -# (C) Copyright 2016 Baptiste Daroussin -# 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2016 Baptiste Daroussin +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -22,7 +22,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/resolvconf_file-dns-updown.sh +2 -2
@@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying /etc/resolv.conf -# (C) Copyright 2024 OpenVPN Inc <[email protected]...> +# Copyright (C) 2024-2026 OpenVPN Inc <[email protected]...> # # SPDX-License-Identifier: BSD-2-Clause #
@@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
distro/dns-scripts/systemd-dns-updown.sh +1 -1
@@ -29,7 +29,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in #
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1645?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id6832e3f56420debc8b19d0144d53ca41abb678b
Gerrit-Change-Number: 1645
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>